eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

AK+Everywhere: Replace custom number parsers with fast_float

Browse Source 
Our floating point number parser was based on the fast_float library:
https://github.com/fastfloat/fast_float

However, our implementation only supports 8-bit characters. To support
UTF-16, we will need to be able to convert char16_t-based strings to
numbers as well. This works out-of-the-box with fast_float.

We can also use fast_float for integer parsing.
This commit is contained in:
Timothy Flynn
2025-06-26 19:06:46 -04:00
committed by Tim Flynn
parent 9fc3e72db2
commit 62d9a84b8d
Notes: github-actions[bot] 2025-07-03 13:53:10 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/62d9a84b8d7
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/5228
Reviewed-by: https://github.com/ADKaster ✅
Reviewed-by: https://github.com/shannonbooth
30 changed files with 413 additions and 3034 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
Libraries/LibJS/Runtime/GlobalObject.cpp
View File

@@ -7,8 +7,8 @@
#include <AK/BuiltinWrappers.h>
#include <AK/CharacterTypes.h>
#include <AK/FloatingPointStringConversions.h>
#include <AK/Hex.h>
#include <AK/StringConversions.h>
#include <AK/UnicodeUtils.h>
#include <AK/Utf16View.h>
#include <AK/Utf8View.h>
@@ -269,12 +269,10 @@ JS_DEFINE_NATIVE_FUNCTION(GlobalObject::parse_float)
// 6. Assert: parsedNumber is a Parse Node.
// 7. Return StringNumericValue of parsedNumber.
auto trimmed_string_view = trimmed_string.bytes_as_string_view();
auto const* begin = trimmed_string_view.characters_without_null_termination();
auto const* end = begin + trimmed_string_view.length();
auto parsed_number = parse_first_floating_point<double>(begin, end);
if (parsed_number.parsed_value())
return parsed_number.value;
auto parsed_number = AK::parse_first_number<double>(trimmed_string_view, TrimWhitespace::No);
if (parsed_number.has_value())
return parsed_number->value;
auto first_code_point = *trimmed_string.code_points().begin();
if (first_code_point == '-' || first_code_point == '+')