eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 09:45:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

AK+Everywhere: Replace custom number parsers with fast_float

Browse Source 
Our floating point number parser was based on the fast_float library:
https://github.com/fastfloat/fast_float

However, our implementation only supports 8-bit characters. To support
UTF-16, we will need to be able to convert char16_t-based strings to
numbers as well. This works out-of-the-box with fast_float.

We can also use fast_float for integer parsing.
This commit is contained in:
Timothy Flynn
2025-06-26 19:06:46 -04:00
committed by Tim Flynn
parent 9fc3e72db2
commit 62d9a84b8d
Notes: github-actions[bot] 2025-07-03 13:53:10 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/62d9a84b8d7
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/5228
Reviewed-by: https://github.com/ADKaster ✅
Reviewed-by: https://github.com/shannonbooth
30 changed files with 413 additions and 3034 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
Libraries/LibURL/Parser.cpp
View File

@@ -12,6 +12,7 @@
#include <AK/Optional.h>
#include <AK/SourceLocation.h>
#include <AK/StringBuilder.h>
#include <AK/StringConversions.h>
#include <AK/StringUtils.h>
#include <AK/Utf8View.h>
#include <LibTextCodec/Decoder.h>
@@ -138,15 +139,7 @@ static Optional<ParsedIPv4Number> parse_ipv4_number(StringView input)
}
// 8. Let output be the mathematical integer value that is represented by input in radix-R notation, using ASCII hex digits for digits with values 0 through 15.
Optional<u32> maybe_output;
if (radix == 8)
maybe_output = AK::StringUtils::convert_to_uint_from_octal(input, TrimWhitespace::No);
else if (radix == 10)
maybe_output = input.to_number<u32>(TrimWhitespace::No);
else if (radix == 16)
maybe_output = AK::StringUtils::convert_to_uint_from_hex(input, TrimWhitespace::No);
else
VERIFY_NOT_REACHED();
auto maybe_output = AK::parse_number<u32>(input, TrimWhitespace::No, radix);
// NOTE: Parsing may have failed due to overflow.
if (!maybe_output.has_value())