eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-30 11:37:16 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Use outputLength instead of length in CShakeParams

Browse Source 
The WebCrypto spec was updated to rename the CSHAKE algorithm
parameter from length to outputLength.
This commit is contained in:
mikiubo
2026-03-21 05:58:52 +01:00
committed by Shannon Booth
parent b7eef098ed
commit 63d8f6b4a9
Notes: github-actions[bot] 2026-03-22 13:14:37 +00:00 
Author: https://github.com/mikiubo
Commit: https://github.com/LadybirdBrowser/ladybird/commit/63d8f6b4a97
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8554
Reviewed-by: https://github.com/shannonbooth ✅
3 changed files with 100 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
Libraries/LibWeb/Crypto/CryptoAlgorithms.cpp
View File

@@ -693,13 +693,13 @@ JS::ThrowCompletionOr<NonnullOwnPtr<AlgorithmParams>> CShakeParams::from_value(J
VERIFY(value.is_object());
auto& object = value.as_object();
if (!MUST(object.has_property("length"_utf16_fly_string))) {
return vm.throw_completion<JS::TypeError>(JS::ErrorType::MissingRequiredProperty, "length");
if (!MUST(object.has_property("outputLength"_utf16_fly_string))) {
return vm.throw_completion<JS::TypeError>(JS::ErrorType::MissingRequiredProperty, "outputLength");
}
auto const length_value = TRY(object.get("length"_utf16_fly_string));
auto const output_length = TRY(object.get("outputLength"_utf16_fly_string));
auto const length = TRY(WebIDL::convert_to_int<WebIDL::UnsignedLong>(vm, length_value, WebIDL::EnforceRange::Yes, WebIDL::Clamp::No));
auto const length = TRY(WebIDL::convert_to_int<WebIDL::UnsignedLong>(vm, output_length, WebIDL::EnforceRange::Yes, WebIDL::Clamp::No));
auto const function_name = TRY(get_optional_buffer_source(vm, object, "functionName"_utf16_fly_string));
@@ -9747,8 +9747,8 @@ WebIDL::ExceptionOr<GC::Ref<JS::ArrayBuffer>> CShake::digest(AlgorithmParams con
{
auto const& normalized_algorithm = static_cast<CShakeParams const&>(params);
// 1. Let length be the length member of normalizedAlgorithm.
auto const& length = normalized_algorithm.length;
// 1. Let outputLength be the outputLength member of normalizedAlgorithm.
auto const& output_length = normalized_algorithm.output_length;
// 2. Let functionName be the functionName member of normalizedAlgorithm if present or the empty octet string otherwise.
auto const& function_name = normalized_algorithm.function_name;
@@ -9768,12 +9768,12 @@ WebIDL::ExceptionOr<GC::Ref<JS::ArrayBuffer>> CShake::digest(AlgorithmParams con
// 4. Let result be the result of performing the cSHAKE128/cSHAKE256 function defined in Section 3 of [NIST-SP800-185]
// using message as the X input parameter,
// length as the L input parameter,
// outputLength as the L input parameter,
// functionName as the N input parameter,
// and customization as the S input parameter.
auto maybe_result = algorithm.digest(
data,
length,
output_length,
customization.map([](auto const& value) { return value.span(); }),
function_name.map([](auto const& value) { return value.span(); }));