eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Maintain precision for large valueAsNumber time inputs

Browse Source
This commit is contained in:
Tim Ledbetter
2026-04-07 11:24:38 +01:00
committed by Shannon Booth
parent e2e401d0e0
commit 6534a58b3c
Notes: github-actions[bot] 2026-04-11 16:29:53 +00:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/6534a58b3c9
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8816
2 changed files with 17 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
Libraries/LibWeb/HTML/HTMLInputElement.cpp
View File

@@ -2603,13 +2603,23 @@ static Utf16String convert_number_to_time_string(double input)
{
// The algorithm to convert a number to a string, given a number input, is as follows: Return a valid time
// string that represents the time that is input milliseconds after midnight on a day with no time changes.
auto seconds = JS::sec_from_time(input);
auto milliseconds = JS::ms_from_time(input);
// NB: We don't use JS::*_from_time helpers here because they lose sub-day precision when |input| is much larger
// than 2^53.
auto time_of_day = fmod(input, JS::ms_per_day);
if (time_of_day < 0)
time_of_day += JS::ms_per_day;
auto hours = static_cast<u32>(time_of_day / JS::ms_per_hour);
auto minutes = static_cast<u32>(fmod(time_of_day, JS::ms_per_hour) / JS::ms_per_minute);
auto seconds = static_cast<u32>(fmod(time_of_day, JS::ms_per_minute) / JS::ms_per_second);
auto milliseconds = static_cast<u32>(fmod(time_of_day, JS::ms_per_second));
if (milliseconds > 0)
return Utf16String::formatted("{:02d}:{:02d}:{:02d}.{:03d}", JS::hour_from_time(input), JS::min_from_time(input), seconds, milliseconds);
return Utf16String::formatted("{:02d}:{:02d}:{:02d}.{:03d}", hours, minutes, seconds, milliseconds);
if (seconds > 0)
return Utf16String::formatted("{:02d}:{:02d}:{:02d}", JS::hour_from_time(input), JS::min_from_time(input), seconds);
return Utf16String::formatted("{:02d}:{:02d}", JS::hour_from_time(input), JS::min_from_time(input));
return Utf16String::formatted("{:02d}:{:02d}:{:02d}", hours, minutes, seconds);
return Utf16String::formatted("{:02d}:{:02d}", hours, minutes);
}
// https://html.spec.whatwg.org/multipage/input.html#local-date-and-time-state-(type=datetime-local):concept-input-value-number-string