eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-30 03:27:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Heap-allocate SerializationRecord in IndexedDB ObjectStoreRecord

Browse Source 
Wrap the SerializationRecord (Vector<u8, 1024>) in an OwnPtr so that
each ObjectStoreRecord is only ~16 bytes instead of ~1040+ bytes.
This makes Vector operations on the records list dramatically cheaper
since memmove now shifts pointers instead of kilobyte-sized buffers.
This commit is contained in:
Andreas Kling
2026-03-20 23:35:29 -05:00
committed by Andreas Kling
parent ea5c543322
commit 6564eff91c
Notes: github-actions[bot] 2026-03-21 13:42:23 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/6564eff91c8
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8546
Reviewed-by: https://github.com/tcl3
6 changed files with 40 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Libraries/LibWeb/IndexedDB/Internal/ObjectStore.cpp
View File

@@ -123,7 +123,7 @@ bool ObjectStore::has_record_with_key(GC::Ref<Key> key)
}) != nullptr;
}
void ObjectStore::store_a_record(ObjectStoreRecord const& record)
void ObjectStore::store_a_record(ObjectStoreRecord record)
{
if (m_mutation_log)
m_mutation_log->note_record_stored(record.key);
@@ -139,7 +139,7 @@ void ObjectStore::store_a_record(ObjectStoreRecord const& record)
else
hi = mid;
}
m_records.insert(lo, record);
m_records.insert(lo, move(record));
}
u64 ObjectStore::count_records_in_range(GC::Ref<IDBKeyRange> range)