eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 09:45:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Properly parse attributes for CSS-connected FontFace

Browse Source 
Previously we would just set the attributes to the serialized
descriptors, even if they were the empty string.

We now apply defaults when we have empty descriptors and apply parsing
logic from the various `set_*` methods (only applicable to `font-family`
so far where we now extract the value from either a string or a
custom-ident)

Fixes an issue in some css/css-shapes WPT tests where we weren't
properly matching fonts.
This commit is contained in:
Callum Law
2026-01-11 00:17:50 +13:00
committed by Sam Atkins
parent bbfe7c64fe
commit 668d3afde0
Notes: github-actions[bot] 2026-01-13 10:41:03 +00:00 
Author: https://github.com/Calme1709
Commit: https://github.com/LadybirdBrowser/ladybird/commit/668d3afde0c
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7420
Reviewed-by: https://github.com/AtkinsSJ ✅
10 changed files with 238 additions and 136 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Tests/LibWeb/Text/input/css/css-connected-font-face-base-url.html
View File

@@ -6,7 +6,7 @@
promiseTest(async () => {
await document.fonts.ready.then(async () => {
await document.fonts
.load('10px \\"Ahem\\"')
.load("10px Ahem")
.then(loadedFonts => {
if (loadedFonts.length == 1) println("PASS!");
else println("FAIL! Didn't match any fonts.");