eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-01 12:07:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Make ESO "fetch group" weakly reference the fetch records

Browse Source 
Otherwise we end up holding on to every fetch record indefinitely.

Found by analyzing GC heap graphs on Discord.
This commit is contained in:
Andreas Kling
2025-07-29 21:23:30 +02:00
committed by Alexander Kalenik
parent 4cbf47dcd2
commit 66a19b8550
Notes: github-actions[bot] 2025-07-30 00:01:41 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/66a19b85501
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/5647
6 changed files with 20 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Libraries/LibWeb/HTML/Scripting/Environments.cpp
View File

@@ -62,7 +62,6 @@ void EnvironmentSettingsObject::visit_edges(Cell::Visitor& visitor)
visitor.visit(m_responsible_event_loop);
visitor.visit(m_module_map);
m_realm_execution_context->visit_edges(visitor);
visitor.visit(m_fetch_group);
visitor.visit(m_storage_manager);
visitor.visit(m_service_worker_registration_object_map);
visitor.visit(m_service_worker_object_map);