eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

Meta: Validate proper formatting for FIXMEs and AD-HOCs

Browse Source
This commit is contained in:
Psychpsyo
2025-11-13 15:12:21 +01:00
committed by Ali Mohammad Pur
parent 100f37995f
commit 6951ef4ee3
Notes: github-actions[bot] 2025-11-14 08:18:28 +00:00 
Author: https://github.com/Psychpsyo
Commit: https://github.com/LadybirdBrowser/ladybird/commit/6951ef4ee3f
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/6810
2 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Libraries/LibWeb/HTML/HTMLMediaElement.cpp
View File

@@ -1259,8 +1259,8 @@ WebIDL::ExceptionOr<void> HTMLMediaElement::process_media_data(Function<void(Str
if (enable == TriState::True)
audio_track->set_enabled(true);
// AD-HOC(ish): According to https://dev.w3.org/html5/html-sourcing-inband-tracks/, kind should be set according to format, and the following criteria within
// the specified formats.
// NB: According to https://dev.w3.org/html5/html-sourcing-inband-tracks/, kind should be set according to format, and the following criteria within
// the specified formats.
// WebM:
// - "main": the FlagDefault element is set on the track
// - "translation": not first audio (video) track
@@ -1318,7 +1318,7 @@ WebIDL::ExceptionOr<void> HTMLMediaElement::process_media_data(Function<void(Str
if (enable == TriState::True)
video_track->set_selected(true);
// AD-HOC(ish): See the comment regarding AudioTrack.kind above with regard to https://dev.w3.org/html5/html-sourcing-inband-tracks/.
// NB: See the comment regarding AudioTrack.kind above with regard to https://dev.w3.org/html5/html-sourcing-inband-tracks/.
video_track->set_kind(enable == TriState::True ? "main"_utf16 : "translation"_utf16);
// 7. Fire an event named addtrack at this VideoTrackList object, using TrackEvent, with the track attribute initialized to the new VideoTrack object.