eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-03 13:02:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Rerun row sizing for auto-height grids

Browse Source 
Percentage row tracks in auto-height grids only participated in our
intrinsic sizing pass. We computed the grid container's intrinsic
height from that pass, but never reran row track sizing with the
now-known height, so percentage rows stayed content-sized and the
imported WPTs had recorded failures.

Reset the mutable track sizing state before rerunning the row pass,
rebuild row gap tracks against the resolved container height, and keep
the automatic content height from the intrinsic pass so parent layout
still resolves auto height correctly. Rebaseline the percentage-row
imports and the grid track parsing import that now improve with the
corrected percentage resolution.
This commit is contained in:
Andreas Kling
2026-04-04 01:37:13 +02:00
committed by Andreas Kling
parent f84edd8173
commit 6994463b1c
Notes: github-actions[bot] 2026-04-04 12:36:58 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/6994463b1c9
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8763
5 changed files with 188 additions and 145 deletions
Download Patch File Download Diff File Expand all files Collapse all files

211
Tests/LibWeb/Text/expected/wpt-import/css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-001.txt
View File

@@ -2,125 +2,124 @@ Harness status: OK
Found 120 tests
16 Pass
104 Fail
120 Pass
Pass .grid 1
Fail .grid 2
Fail .grid 3
Pass .grid 2
Pass .grid 3
Pass .grid 4
Fail .grid 5
Fail .grid 6
Pass .grid 5
Pass .grid 6
Pass .grid 7
Fail .grid 8
Fail .grid 9
Pass .grid 8
Pass .grid 9
Pass .grid 10
Fail .grid 11
Fail .grid 12
Pass .grid 11
Pass .grid 12
Pass .grid 13
Fail .grid 14
Fail .grid 15
Pass .grid 14
Pass .grid 15
Pass .grid 16
Fail .grid 17
Fail .grid 18
Pass .grid 17
Pass .grid 18
Pass .grid 19
Fail .grid 20
Fail .grid 21
Pass .grid 20
Pass .grid 21
Pass .grid 22
Fail .grid 23
Fail .grid 24
Fail .grid 25
Fail .grid 26
Fail .grid 27
Fail .grid 28
Fail .grid 29
Fail .grid 30
Fail .grid 31
Fail .grid 32
Fail .grid 33
Fail .grid 34
Fail .grid 35
Fail .grid 36
Fail .grid 37
Fail .grid 38
Fail .grid 39
Fail .grid 40
Fail .grid 41
Fail .grid 42
Fail .grid 43
Fail .grid 44
Fail .grid 45
Fail .grid 46
Fail .grid 47
Fail .grid 48
Fail .grid 49
Fail .grid 50
Fail .grid 51
Fail .grid 52
Fail .grid 53
Fail .grid 54
Fail .grid 55
Fail .grid 56
Fail .grid 57
Fail .grid 58
Fail .grid 59
Fail .grid 60
Fail .grid 61
Fail .grid 62
Fail .grid 63
Fail .grid 64
Fail .grid 65
Fail .grid 66
Fail .grid 67
Fail .grid 68
Fail .grid 69
Fail .grid 70
Fail .grid 71
Fail .grid 72
Pass .grid 23
Pass .grid 24
Pass .grid 25
Pass .grid 26
Pass .grid 27
Pass .grid 28
Pass .grid 29
Pass .grid 30
Pass .grid 31
Pass .grid 32
Pass .grid 33
Pass .grid 34
Pass .grid 35
Pass .grid 36
Pass .grid 37
Pass .grid 38
Pass .grid 39
Pass .grid 40
Pass .grid 41
Pass .grid 42
Pass .grid 43
Pass .grid 44
Pass .grid 45
Pass .grid 46
Pass .grid 47
Pass .grid 48
Pass .grid 49
Pass .grid 50
Pass .grid 51
Pass .grid 52
Pass .grid 53
Pass .grid 54
Pass .grid 55
Pass .grid 56
Pass .grid 57
Pass .grid 58
Pass .grid 59
Pass .grid 60
Pass .grid 61
Pass .grid 62
Pass .grid 63
Pass .grid 64
Pass .grid 65
Pass .grid 66
Pass .grid 67
Pass .grid 68
Pass .grid 69
Pass .grid 70
Pass .grid 71
Pass .grid 72
Pass .grid 73
Fail .grid 74
Fail .grid 75
Fail .grid 76
Fail .grid 77
Fail .grid 78
Pass .grid 74
Pass .grid 75
Pass .grid 76
Pass .grid 77
Pass .grid 78
Pass .grid 79
Fail .grid 80
Fail .grid 81
Fail .grid 82
Fail .grid 83
Fail .grid 84
Pass .grid 80
Pass .grid 81
Pass .grid 82
Pass .grid 83
Pass .grid 84
Pass .grid 85
Fail .grid 86
Fail .grid 87
Fail .grid 88
Fail .grid 89
Fail .grid 90
Pass .grid 86
Pass .grid 87
Pass .grid 88
Pass .grid 89
Pass .grid 90
Pass .grid 91
Fail .grid 92
Fail .grid 93
Fail .grid 94
Fail .grid 95
Fail .grid 96
Pass .grid 92
Pass .grid 93
Pass .grid 94
Pass .grid 95
Pass .grid 96
Pass .grid 97
Fail .grid 98
Fail .grid 99
Fail .grid 100
Fail .grid 101
Fail .grid 102
Pass .grid 98
Pass .grid 99
Pass .grid 100
Pass .grid 101
Pass .grid 102
Pass .grid 103
Fail .grid 104
Fail .grid 105
Fail .grid 106
Fail .grid 107
Fail .grid 108
Pass .grid 104
Pass .grid 105
Pass .grid 106
Pass .grid 107
Pass .grid 108
Pass .grid 109
Fail .grid 110
Fail .grid 111
Fail .grid 112
Fail .grid 113
Fail .grid 114
Pass .grid 110
Pass .grid 111
Pass .grid 112
Pass .grid 113
Pass .grid 114
Pass .grid 115
Fail .grid 116
Fail .grid 117
Fail .grid 118
Fail .grid 119
Fail .grid 120
Pass .grid 116
Pass .grid 117
Pass .grid 118
Pass .grid 119
Pass .grid 120

10
Tests/LibWeb/Text/expected/wpt-import/css/css-grid/grid-definition/grid-percentage-rows-indefinite-height-002.txt
View File

@@ -2,8 +2,8 @@ Harness status: OK
Found 4 tests
4 Fail
Fail .grid 1
Fail .grid 2
Fail .grid 3
Fail .grid 4
4 Pass
Pass .grid 1
Pass .grid 2
Pass .grid 3
Pass .grid 4