eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Store CSS color name in CSSRGB

Browse Source 
When serializing an sRGB color value that originated from a named color,
it should return the color name converted to ASCII lowercase. This
requires storing the color name (if it has one).

This change also requires explicitly removing the color names when
computing style, because computed color values do not retain their name.
It also requires removing a caching optimization in create_from_color(),
because adding the name means that the cached value might be wrong.

This fixes some WPT subtests, and also required updating some of our own
tests.
This commit is contained in:
Milo van der Tier
2024-11-24 18:47:15 +01:00
committed by Andreas Kling
parent ff311c1560
commit 6bb8bf189f
Notes: github-actions[bot] 2024-11-25 10:52:53 +00:00 
Author: https://github.com/milotier
Commit: https://github.com/LadybirdBrowser/ladybird/commit/6bb8bf189f2
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2551
Reviewed-by: https://github.com/tcl3
16 changed files with 133 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
Tests/LibWeb/Text/expected/wpt-import/css/css-nesting/cssom.txt
View File

@@ -6,19 +6,19 @@ Rerun
Found 13 tests
1 Pass
12 Fail
11 Pass
2 Fail
Details
Result Test Name MessageFail CSSStyleRule is a CSSGroupingRule
Fail Simple CSSOM manipulation of subrules
Fail Simple CSSOM manipulation of subrules 1
Fail Simple CSSOM manipulation of subrules 2
Fail Simple CSSOM manipulation of subrules 3
Fail Simple CSSOM manipulation of subrules 4
Fail Simple CSSOM manipulation of subrules 5
Fail Simple CSSOM manipulation of subrules 6
Fail Simple CSSOM manipulation of subrules 7
Pass Simple CSSOM manipulation of subrules
Pass Simple CSSOM manipulation of subrules 1
Pass Simple CSSOM manipulation of subrules 2
Pass Simple CSSOM manipulation of subrules 3
Pass Simple CSSOM manipulation of subrules 4
Pass Simple CSSOM manipulation of subrules 5
Pass Simple CSSOM manipulation of subrules 6
Pass Simple CSSOM manipulation of subrules 7
Fail Simple CSSOM manipulation of subrules 8
Fail Simple CSSOM manipulation of subrules 9
Fail Simple CSSOM manipulation of subrules 10
Pass Simple CSSOM manipulation of subrules 9
Pass Simple CSSOM manipulation of subrules 10
Pass Mutating the selectorText of outer rule invalidates inner rules

5
Tests/LibWeb/Text/expected/wpt-import/css/css-nesting/invalid-inner-rules.txt
View File

@@ -6,7 +6,8 @@ Rerun
Found 2 tests
2 Fail
1 Pass
1 Fail
Details
Result Test Name MessageFail Simple CSSOM manipulation of subrules
Result Test Name MessagePass Simple CSSOM manipulation of subrules
Fail Simple CSSOM manipulation of subrules 1

25
Tests/LibWeb/Text/expected/wpt-import/css/css-nesting/serialize-group-rules-with-decls.txt
View File

@@ -6,20 +6,19 @@ Rerun
Found 15 tests
4 Pass
11 Fail
15 Pass
Details
Result Test Name MessageFail Declarations are serialized on one line, rules on two.
Fail Mixed declarations/rules are on two lines.
Fail Implicit rule is serialized
Fail Implicit rule not removed
Fail Implicit + empty hover rule
Fail Implicit like rule not in first position
Fail Two implicit-like rules
Fail Implicit like rule after decls
Fail Implicit like rule after decls, missing closing braces
Fail Implicit like rule with other selectors
Fail Implicit-like rule in style rule
Result Test Name MessagePass Declarations are serialized on one line, rules on two.
Pass Mixed declarations/rules are on two lines.
Pass Implicit rule is serialized
Pass Implicit rule not removed
Pass Implicit + empty hover rule
Pass Implicit like rule not in first position
Pass Two implicit-like rules
Pass Implicit like rule after decls
Pass Implicit like rule after decls, missing closing braces
Pass Implicit like rule with other selectors
Pass Implicit-like rule in style rule
Pass Empty conditional rule
Pass Empty style rule
Pass Empty conditional inside style rule