eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-28 10:37:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/Layout: Spec-comment Table "algorithm for processing rows"

Browse Source 
Some of this is rearranged for clarity, but it's mostly the exact same
code. Steps 3, 10, 11, and 15 are new, but don't have any effect until
we implement downward-growing cells.
This commit is contained in:
Sam Atkins
2025-11-27 12:49:51 +00:00
committed by Andreas Kling
parent 2af63149ec
commit 6ca69d9e26
Notes: github-actions[bot] 2025-11-30 10:49:07 +00:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/LadybirdBrowser/ladybird/commit/6ca69d9e262
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/6959
2 changed files with 89 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
Libraries/LibWeb/HTML/HTMLTableCellElement.cpp
View File

@@ -129,13 +129,14 @@ void HTMLTableCellElement::apply_presentational_hints(GC::Ref<CSS::CascadedPrope
// https://html.spec.whatwg.org/multipage/tables.html#algorithm-for-processing-rows
WebIDL::UnsignedLong HTMLTableCellElement::col_span() const
{
// If the current cell has a colspan attribute, then parse that attribute's value, and let colspan be the result.
// If parsing that value failed, or returned zero, or if the attribute is absent, then let colspan be 1, instead.
auto col_span_attribute = get_attribute(HTML::AttributeNames::colspan);
if (!col_span_attribute.has_value())
return 1;
auto optional_value_digits = Web::HTML::parse_non_negative_integer_digits(*col_span_attribute);
// If parsing that value failed, or returned zero, or if the attribute is absent, then let colspan be 1, instead.
if (!optional_value_digits.has_value())
return 1;
@@ -143,7 +144,7 @@ WebIDL::UnsignedLong HTMLTableCellElement::col_span() const
if (optional_value == 0)
return 1;
// NOTE: If there is no value at this point the value must be larger than NumericLimits<i64>::max(), so return the maximum value of 1000.
// NB: If there is no value at this point the value must be larger than NumericLimits<i64>::max(), so return the maximum value of 1000.
if (!optional_value.has_value())
return 1000;
@@ -168,11 +169,12 @@ void HTMLTableCellElement::set_col_span(WebIDL::UnsignedLong value)
// https://html.spec.whatwg.org/multipage/tables.html#algorithm-for-processing-rows
WebIDL::UnsignedLong HTMLTableCellElement::row_span() const
{
// If the current cell has a rowspan attribute, then parse that attribute's value, and let rowspan be the result.
// If parsing that value failed or if the attribute is absent, then let rowspan be 1, instead.
auto row_span_attribute = get_attribute(HTML::AttributeNames::rowspan);
if (!row_span_attribute.has_value())
return 1;
// If parsing that value failed or if the attribute is absent, then let rowspan be 1, instead.
auto optional_value_digits = Web::HTML::parse_non_negative_integer_digits(*row_span_attribute);
if (!optional_value_digits.has_value())
return 1;
@@ -180,7 +182,7 @@ WebIDL::UnsignedLong HTMLTableCellElement::row_span() const
auto optional_value = optional_value_digits->to_number<i64>(TrimWhitespace::No);
// If rowspan is greater than 65534, let it be 65534 instead.
// NOTE: If there is no value at this point the value must be larger than NumericLimits<i64>::max(), so return the maximum value of 65534.
// NB: If there is no value at this point the value must be larger than NumericLimits<i64>::max(), so return the maximum value of 65534.
if (!optional_value.has_value() || *optional_value > 65534)
return 65534;