eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWebView+UI: Generate actions to open about: pages

Browse Source
This commit is contained in:
Timothy Flynn
2025-09-17 09:18:08 -04:00
committed by Tim Flynn
parent ce331cbcd5
commit 6d30b0f4d4
Notes: github-actions[bot] 2025-09-18 11:28:53 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/6d30b0f4d4e
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/6221
Reviewed-by: https://github.com/AtkinsSJ
Reviewed-by: https://github.com/konradekk
7 changed files with 45 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
UI/AppKit/Application/ApplicationDelegate.mm
View File

@@ -126,32 +126,6 @@
#pragma mark - Private methods
- (void)openAboutVersionPage:(id)sender
{
auto* current_tab = [NSApp keyWindow];
if (![current_tab isKindOfClass:[Tab class]]) {
return;
}
[self createNewTab:URL::URL(URL::about_version())
fromTab:(Tab*)current_tab
activateTab:Web::HTML::ActivateTab::Yes];
}
- (void)openSettings:(id)sender
{
[self createNewTab:URL::URL::about("settings"_string)
fromTab:self.active_tab
activateTab:Web::HTML::ActivateTab::Yes];
}
- (void)openTaskManager:(id)sender
{
[self createNewTab:URL::URL::about("processes"_string)
fromTab:self.active_tab
activateTab:Web::HTML::ActivateTab::Yes];
}
- (void)openLocation:(id)sender
{
auto* current_tab = [NSApp keyWindow];
@@ -269,14 +243,10 @@
auto* process_name = [[NSProcessInfo processInfo] processName];
auto* submenu = [[NSMenu alloc] initWithTitle:process_name];
[submenu addItem:[[NSMenuItem alloc] initWithTitle:[NSString stringWithFormat:@"About %@", process_name]
action:@selector(openAboutVersionPage:)
keyEquivalent:@""]];
[submenu addItem:Ladybird::create_application_menu_item(WebView::Application::the().open_about_page_action())];
[submenu addItem:[NSMenuItem separatorItem]];
[submenu addItem:[[NSMenuItem alloc] initWithTitle:@"Settings"
action:@selector(openSettings:)
keyEquivalent:@","]];
[submenu addItem:Ladybird::create_application_menu_item(WebView::Application::the().open_settings_page_action())];
[submenu addItem:[NSMenuItem separatorItem]];
[submenu addItem:[[NSMenuItem alloc] initWithTitle:[NSString stringWithFormat:@"Hide %@", process_name]
@@ -424,9 +394,7 @@
keyEquivalent:@"I"];
[submenu addItem:self.toggle_devtools_menu_item];
[submenu addItem:[[NSMenuItem alloc] initWithTitle:@"Open Task Manager"
action:@selector(openTaskManager:)
keyEquivalent:@"M"]];
[submenu addItem:Ladybird::create_application_menu_item(WebView::Application::the().open_processes_page_action())];
[menu setSubmenu:submenu];
return menu;