eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 17:55:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb+Browser+Ladybird: Use JS::SafeFunction for EventLoop callbacks

Browse Source 
This automatically protects captured objects from being GC'd before the
callback runs.
This commit is contained in:
Sam Atkins
2023-04-21 12:13:04 +01:00
committed by Linus Groh
parent 892470a912
commit 6d93e03211
Notes: sideshowbarker 2024-07-17 02:57:43 +09:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/SerenityOS/serenity/commit/6d93e03211
Pull-request: https://github.com/SerenityOS/serenity/pull/18441
Reviewed-by: https://github.com/linusg
Reviewed-by: https://github.com/nico
Reviewed-by: https://github.com/trflynn89
11 changed files with 19 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Libraries/LibWeb/HTML/EventLoop/EventLoop.cpp
View File

@@ -51,7 +51,7 @@ EventLoop& main_thread_event_loop()
}
// https://html.spec.whatwg.org/multipage/webappapis.html#spin-the-event-loop
void EventLoop::spin_until(Function<bool()> goal_condition)
void EventLoop::spin_until(JS::SafeFunction<bool()> goal_condition)
{
// FIXME: 1. Let task be the event loop's currently running task.