mirror of
https://github.com/LadybirdBrowser/ladybird
synced 2026-04-26 17:55:07 +02:00
AK+Everywhere: Rename String to DeprecatedString
We have a new, improved string type coming up in AK (OOM aware, no null state), and while it's going to use UTF-8, the name UTF8String is a mouthful - so let's free up the String name by renaming the existing class. Making the old one have an annoying name will hopefully also help with quick adoption :^)
This commit is contained in:
committed by
Andreas Kling
parent
f74251606d
commit
6e19ab2bbc
Notes:
sideshowbarker
2024-07-18 04:38:32 +09:00
Author: https://github.com/linusg Commit: https://github.com/SerenityOS/serenity/commit/6e19ab2bbc Pull-request: https://github.com/SerenityOS/serenity/pull/16311 Reviewed-by: https://github.com/BertalanD Reviewed-by: https://github.com/MacDue
@@ -41,7 +41,7 @@ size_t ResolvedCSSStyleDeclaration::length() const
|
||||
return 0;
|
||||
}
|
||||
|
||||
String ResolvedCSSStyleDeclaration::item(size_t index) const
|
||||
DeprecatedString ResolvedCSSStyleDeclaration::item(size_t index) const
|
||||
{
|
||||
(void)index;
|
||||
return {};
|
||||
@@ -562,20 +562,20 @@ WebIDL::ExceptionOr<void> ResolvedCSSStyleDeclaration::set_property(PropertyID,
|
||||
}
|
||||
|
||||
// https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-removeproperty
|
||||
WebIDL::ExceptionOr<String> ResolvedCSSStyleDeclaration::remove_property(PropertyID)
|
||||
WebIDL::ExceptionOr<DeprecatedString> ResolvedCSSStyleDeclaration::remove_property(PropertyID)
|
||||
{
|
||||
// 1. If the computed flag is set, then throw a NoModificationAllowedError exception.
|
||||
return WebIDL::NoModificationAllowedError::create(realm(), "Cannot remove properties from result of getComputedStyle()");
|
||||
}
|
||||
|
||||
String ResolvedCSSStyleDeclaration::serialized() const
|
||||
DeprecatedString ResolvedCSSStyleDeclaration::serialized() const
|
||||
{
|
||||
// https://www.w3.org/TR/cssom/#dom-cssstyledeclaration-csstext
|
||||
// If the computed flag is set, then return the empty string.
|
||||
|
||||
// NOTE: ResolvedCSSStyleDeclaration is something you would only get from window.getComputedStyle(),
|
||||
// which returns what the spec calls "resolved style". The "computed flag" is always set here.
|
||||
return String::empty();
|
||||
return DeprecatedString::empty();
|
||||
}
|
||||
|
||||
// https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-csstext
|
||||
|
||||
Reference in New Issue
Block a user