eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 09:45:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/HTML: Implement <input> element valueAsNumber for 'week'

Browse Source 
One point to note is that I am not entirely sure what the result
of the pre-existing valueAsNumber test should be for this strange
case which does not lie exactly on a week/day boundary. Chrome
gives a negative timestamp, which seems more wrong than the result
we give, and neither gecko or WebKit appear to support the 'week'
type. So I'm considering this result acceptable for now, and this
may be something that will need more WPT tests added in the future.
This commit is contained in:
Shannon Booth
2025-02-07 17:24:35 +13:00
committed by Sam Atkins
parent a808cd1631
commit 6e257897f6
Notes: github-actions[bot] 2025-02-22 19:10:40 +00:00 
Author: https://github.com/shannonbooth
Commit: https://github.com/LadybirdBrowser/ladybird/commit/6e257897f6a
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/3485
Reviewed-by: https://github.com/AtkinsSJ ✅
Reviewed-by: https://github.com/gmta
Reviewed-by: https://github.com/trflynn89
5 changed files with 120 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Tests/LibWeb/Text/expected/HTML/HTMLInputElement-valueAsNumber.txt
View File

@@ -33,7 +33,7 @@ email threw exception: InvalidStateError: valueAsNumber: Invalid input type used
password threw exception: InvalidStateError: valueAsNumber: Invalid input type used
date did not throw: NaN
month did not throw: 100
week did not throw: NaN
week did not throw: 345600000
time did not throw: NaN
datetime-local did not throw: NaN
color threw exception: InvalidStateError: valueAsNumber: Invalid input type used