eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated

Browse Source 
This is a monster patch that turns all EventTargets into GC-allocated
PlatformObjects. Their C++ wrapper classes are removed, and the LibJS
garbage collector is now responsible for their lifetimes.

There's a fair amount of hacks and band-aids in this patch, and we'll
have a lot of cleanup to do after this.
This commit is contained in:
Andreas Kling
2022-08-28 13:42:07 +02:00
parent bb547ce1c4
commit 6f433c8656
Notes: sideshowbarker 2024-07-17 07:28:15 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/6f433c8656
Pull-request: https://github.com/SerenityOS/serenity/pull/14816
Reviewed-by: https://github.com/ADKaster
Reviewed-by: https://github.com/linusg ✅
445 changed files with 4797 additions and 4268 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
Userland/Libraries/LibWeb/DOM/Comment.h
View File

@@ -12,18 +12,21 @@
namespace Web::DOM {
class Comment final : public CharacterData {
public:
using WrapperType = Bindings::CommentWrapper;
WEB_PLATFORM_OBJECT(Comment, CharacterData);
explicit Comment(Document&, String const&);
public:
static JS::NonnullGCPtr<Comment> create_with_global_object(HTML::Window&, String const& data);
virtual ~Comment() override = default;
virtual FlyString node_name() const override { return "#comment"; }
static NonnullRefPtr<Comment> create_with_global_object(Bindings::WindowObject& window, String const& data);
private:
explicit Comment(Document&, String const&);
};
template<>
inline bool Node::fast_is<Comment>() const { return is_comment(); }
}
WRAPPER_HACK(Comment, Web::DOM)