eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-30 11:37:16 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated

Browse Source 
This is a monster patch that turns all EventTargets into GC-allocated
PlatformObjects. Their C++ wrapper classes are removed, and the LibJS
garbage collector is now responsible for their lifetimes.

There's a fair amount of hacks and band-aids in this patch, and we'll
have a lot of cleanup to do after this.
This commit is contained in:
Andreas Kling
2022-08-28 13:42:07 +02:00
parent bb547ce1c4
commit 6f433c8656
Notes: sideshowbarker 2024-07-17 07:28:15 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/6f433c8656
Pull-request: https://github.com/SerenityOS/serenity/pull/14816
Reviewed-by: https://github.com/ADKaster
Reviewed-by: https://github.com/linusg ✅
445 changed files with 4797 additions and 4268 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Userland/Libraries/LibWeb/DOM/HTMLCollection.h
View File

@@ -9,6 +9,7 @@
#include <AK/FlyString.h>
#include <AK/Function.h>
#include <AK/Noncopyable.h>
#include <LibJS/Heap/GCPtr.h>
#include <LibWeb/Bindings/Wrappable.h>
#include <LibWeb/Forward.h>
@@ -45,7 +46,7 @@ public:
Element* item(size_t index) const;
Element* named_item(FlyString const& name) const;
Vector<NonnullRefPtr<Element>> collect_matching_elements() const;
JS::MarkedVector<Element*> collect_matching_elements() const;
Vector<String> supported_property_names() const;
bool is_supported_property_index(u32) const;
@@ -53,10 +54,10 @@ public:
protected:
HTMLCollection(ParentNode& root, Function<bool(Element const&)> filter);
NonnullRefPtr<ParentNode> root() { return m_root; }
JS::NonnullGCPtr<ParentNode> root() { return *m_root; }
private:
NonnullRefPtr<ParentNode> m_root;
JS::Handle<ParentNode> m_root;
Function<bool(Element const&)> m_filter;
};