eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-27 10:07:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated

Browse Source 
This is a monster patch that turns all EventTargets into GC-allocated
PlatformObjects. Their C++ wrapper classes are removed, and the LibJS
garbage collector is now responsible for their lifetimes.

There's a fair amount of hacks and band-aids in this patch, and we'll
have a lot of cleanup to do after this.
This commit is contained in:
Andreas Kling
2022-08-28 13:42:07 +02:00
parent bb547ce1c4
commit 6f433c8656
Notes: sideshowbarker 2024-07-17 07:28:15 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/6f433c8656
Pull-request: https://github.com/SerenityOS/serenity/pull/14816
Reviewed-by: https://github.com/ADKaster
Reviewed-by: https://github.com/linusg ✅
445 changed files with 4797 additions and 4268 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Userland/Libraries/LibWeb/DOM/NonElementParentNode.h
View File

@@ -16,9 +16,9 @@ namespace Web::DOM {
template<typename NodeType>
class NonElementParentNode {
public:
RefPtr<Element> get_element_by_id(FlyString const& id) const
JS::GCPtr<Element> get_element_by_id(FlyString const& id) const
{
RefPtr<Element> found_element;
JS::GCPtr<Element> found_element;
static_cast<NodeType const*>(this)->template for_each_in_inclusive_subtree_of_type<Element>([&](auto& element) {
if (element.attribute(HTML::AttributeNames::id) == id) {
found_element = &element;
@@ -28,7 +28,7 @@ public:
});
return found_element;
}
RefPtr<Element> get_element_by_id(FlyString const& id)
JS::GCPtr<Element> get_element_by_id(FlyString const& id)
{
return const_cast<NonElementParentNode const*>(this)->get_element_by_id(id);
}