eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-27 02:05:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated

Browse Source 
This is a monster patch that turns all EventTargets into GC-allocated
PlatformObjects. Their C++ wrapper classes are removed, and the LibJS
garbage collector is now responsible for their lifetimes.

There's a fair amount of hacks and band-aids in this patch, and we'll
have a lot of cleanup to do after this.
This commit is contained in:
Andreas Kling
2022-08-28 13:42:07 +02:00
parent bb547ce1c4
commit 6f433c8656
Notes: sideshowbarker 2024-07-17 07:28:15 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/6f433c8656
Pull-request: https://github.com/SerenityOS/serenity/pull/14816
Reviewed-by: https://github.com/ADKaster
Reviewed-by: https://github.com/linusg ✅
445 changed files with 4797 additions and 4268 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
Userland/Libraries/LibWeb/DOM/ProcessingInstruction.h
View File

@@ -12,10 +12,9 @@
namespace Web::DOM {
class ProcessingInstruction final : public CharacterData {
public:
using WrapperType = Bindings::ProcessingInstructionWrapper;
WEB_PLATFORM_OBJECT(ProcessingInstruction, CharacterData);
ProcessingInstruction(Document&, String const& data, String const& target);
public:
virtual ~ProcessingInstruction() override = default;
virtual FlyString node_name() const override { return m_target; }
@@ -23,6 +22,8 @@ public:
String const& target() const { return m_target; }
private:
ProcessingInstruction(Document&, String const& data, String const& target);
String m_target;
};
@@ -30,3 +31,5 @@ template<>
inline bool Node::fast_is<ProcessingInstruction>() const { return node_type() == (u16)NodeType::PROCESSING_INSTRUCTION_NODE; }
}
WRAPPER_HACK(ProcessingInstruction, Web::DOM)