eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-28 10:37:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated

Browse Source 
This is a monster patch that turns all EventTargets into GC-allocated
PlatformObjects. Their C++ wrapper classes are removed, and the LibJS
garbage collector is now responsible for their lifetimes.

There's a fair amount of hacks and band-aids in this patch, and we'll
have a lot of cleanup to do after this.
This commit is contained in:
Andreas Kling
2022-08-28 13:42:07 +02:00
parent bb547ce1c4
commit 6f433c8656
Notes: sideshowbarker 2024-07-17 07:28:15 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/6f433c8656
Pull-request: https://github.com/SerenityOS/serenity/pull/14816
Reviewed-by: https://github.com/ADKaster
Reviewed-by: https://github.com/linusg ✅
445 changed files with 4797 additions and 4268 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
Userland/Libraries/LibWeb/DOM/StaticNodeList.h
View File

@@ -14,10 +14,7 @@ namespace Web::DOM {
class StaticNodeList : public NodeList {
public:
static NonnullRefPtr<NodeList> create(NonnullRefPtrVector<Node> static_nodes)
{
return adopt_ref(*new StaticNodeList(move(static_nodes)));
}
static NonnullRefPtr<NodeList> create(Vector<JS::Handle<Node>> static_nodes);
virtual ~StaticNodeList() override = default;
@@ -27,9 +24,9 @@ public:
virtual bool is_supported_property_index(u32) const override;
private:
StaticNodeList(NonnullRefPtrVector<Node>&& static_nodes);
StaticNodeList(Vector<JS::Handle<Node>> static_nodes);
NonnullRefPtrVector<Node> m_static_nodes;
Vector<JS::Handle<Node>> m_static_nodes;
};
}