mirror of
https://github.com/LadybirdBrowser/ladybird
synced 2026-04-30 11:37:16 +02:00
LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated
This is a monster patch that turns all EventTargets into GC-allocated PlatformObjects. Their C++ wrapper classes are removed, and the LibJS garbage collector is now responsible for their lifetimes. There's a fair amount of hacks and band-aids in this patch, and we'll have a lot of cleanup to do after this.
This commit is contained in:
Notes:
sideshowbarker
2024-07-17 07:28:15 +09:00
Author: https://github.com/awesomekling Commit: https://github.com/SerenityOS/serenity/commit/6f433c8656 Pull-request: https://github.com/SerenityOS/serenity/pull/14816 Reviewed-by: https://github.com/ADKaster Reviewed-by: https://github.com/linusg ✅
@@ -11,8 +11,9 @@
|
||||
namespace Web::HTML {
|
||||
|
||||
class BrowsingContextContainer : public HTMLElement {
|
||||
WEB_PLATFORM_OBJECT(BrowsingContextContainer, HTMLElement);
|
||||
|
||||
public:
|
||||
BrowsingContextContainer(DOM::Document&, DOM::QualifiedName);
|
||||
virtual ~BrowsingContextContainer() override;
|
||||
|
||||
BrowsingContext* nested_browsing_context() { return m_nested_browsing_context; }
|
||||
@@ -26,6 +27,8 @@ public:
|
||||
DOM::Document const* get_svg_document() const;
|
||||
|
||||
protected:
|
||||
BrowsingContextContainer(DOM::Document&, DOM::QualifiedName);
|
||||
|
||||
void create_new_nested_browsing_context();
|
||||
void discard_nested_browsing_context();
|
||||
|
||||
@@ -41,3 +44,5 @@ namespace Web::DOM {
|
||||
template<>
|
||||
inline bool Node::fast_is<HTML::BrowsingContextContainer>() const { return is_browsing_context_container(); }
|
||||
}
|
||||
|
||||
WRAPPER_HACK(BrowsingContextContainer, Web::HTML)
|
||||
|
||||
Reference in New Issue
Block a user