eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 09:45:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated

Browse Source 
This is a monster patch that turns all EventTargets into GC-allocated
PlatformObjects. Their C++ wrapper classes are removed, and the LibJS
garbage collector is now responsible for their lifetimes.

There's a fair amount of hacks and band-aids in this patch, and we'll
have a lot of cleanup to do after this.
This commit is contained in:
Andreas Kling
2022-08-28 13:42:07 +02:00
parent bb547ce1c4
commit 6f433c8656
Notes: sideshowbarker 2024-07-17 07:28:15 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/6f433c8656
Pull-request: https://github.com/SerenityOS/serenity/pull/14816
Reviewed-by: https://github.com/ADKaster
Reviewed-by: https://github.com/linusg ✅
445 changed files with 4797 additions and 4268 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
Userland/Libraries/LibWeb/HTML/HTMLBaseElement.h
View File

@@ -11,10 +11,9 @@
namespace Web::HTML {
class HTMLBaseElement final : public HTMLElement {
public:
using WrapperType = Bindings::HTMLBaseElementWrapper;
WEB_PLATFORM_OBJECT(HTMLBaseElement, HTMLElement);
HTMLBaseElement(DOM::Document&, DOM::QualifiedName);
public:
virtual ~HTMLBaseElement() override;
String href() const;
@@ -26,6 +25,8 @@ public:
virtual void parse_attribute(FlyString const& name, String const& value) override;
private:
HTMLBaseElement(DOM::Document&, DOM::QualifiedName);
virtual bool is_html_base_element() const override { return true; }
// https://html.spec.whatwg.org/multipage/semantics.html#frozen-base-url
@@ -41,3 +42,5 @@ namespace Web::DOM {
template<>
inline bool Node::fast_is<HTML::HTMLBaseElement>() const { return is_html_base_element(); }
}
WRAPPER_HACK(HTMLBaseElement, Web::HTML)