eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 17:55:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated

Browse Source 
This is a monster patch that turns all EventTargets into GC-allocated
PlatformObjects. Their C++ wrapper classes are removed, and the LibJS
garbage collector is now responsible for their lifetimes.

There's a fair amount of hacks and band-aids in this patch, and we'll
have a lot of cleanup to do after this.
This commit is contained in:
Andreas Kling
2022-08-28 13:42:07 +02:00
parent bb547ce1c4
commit 6f433c8656
Notes: sideshowbarker 2024-07-17 07:28:15 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/6f433c8656
Pull-request: https://github.com/SerenityOS/serenity/pull/14816
Reviewed-by: https://github.com/ADKaster
Reviewed-by: https://github.com/linusg ✅
445 changed files with 4797 additions and 4268 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Userland/Libraries/LibWeb/HTML/HTMLObjectElement.h
View File

@@ -19,6 +19,7 @@ class HTMLObjectElement final
: public BrowsingContextContainer
, public FormAssociatedElement
, public ResourceClient {
WEB_PLATFORM_OBJECT(HTMLObjectElement, BrowsingContextContainer)
FORM_ASSOCIATED_ELEMENT(BrowsingContextContainer, HTMLObjectElement)
enum class Representation {
@@ -29,9 +30,6 @@ class HTMLObjectElement final
};
public:
using WrapperType = Bindings::HTMLObjectElementWrapper;
HTMLObjectElement(DOM::Document&, DOM::QualifiedName);
virtual ~HTMLObjectElement() override;
virtual void parse_attribute(FlyString const& name, String const& value) override;
@@ -46,6 +44,8 @@ public:
virtual bool is_listed() const override { return true; }
private:
HTMLObjectElement(DOM::Document&, DOM::QualifiedName);
virtual RefPtr<Layout::Node> create_layout_node(NonnullRefPtr<CSS::StyleProperties>) override;
bool has_ancestor_media_element_or_object_element_not_showing_fallback_content() const;
@@ -67,3 +67,5 @@ private:
};
}
WRAPPER_HACK(HTMLObjectElement, Web::HTML)