mirror of
https://github.com/LadybirdBrowser/ladybird
synced 2026-04-26 17:55:07 +02:00
LibWeb+LibJS: Make the EventTarget hierarchy (incl. DOM) GC-allocated
This is a monster patch that turns all EventTargets into GC-allocated PlatformObjects. Their C++ wrapper classes are removed, and the LibJS garbage collector is now responsible for their lifetimes. There's a fair amount of hacks and band-aids in this patch, and we'll have a lot of cleanup to do after this.
This commit is contained in:
Notes:
sideshowbarker
2024-07-17 07:28:15 +09:00
Author: https://github.com/awesomekling Commit: https://github.com/SerenityOS/serenity/commit/6f433c8656 Pull-request: https://github.com/SerenityOS/serenity/pull/14816 Reviewed-by: https://github.com/ADKaster Reviewed-by: https://github.com/linusg ✅
@@ -11,10 +11,9 @@
|
||||
namespace Web::HTML {
|
||||
|
||||
class HTMLProgressElement final : public HTMLElement {
|
||||
public:
|
||||
using WrapperType = Bindings::HTMLProgressElementWrapper;
|
||||
WEB_PLATFORM_OBJECT(HTMLProgressElement, HTMLElement);
|
||||
|
||||
HTMLProgressElement(DOM::Document&, DOM::QualifiedName);
|
||||
public:
|
||||
virtual ~HTMLProgressElement() override;
|
||||
|
||||
virtual RefPtr<Layout::Node> create_layout_node(NonnullRefPtr<CSS::StyleProperties>) override;
|
||||
@@ -34,9 +33,13 @@ public:
|
||||
bool using_system_appearance() const;
|
||||
|
||||
private:
|
||||
HTMLProgressElement(DOM::Document&, DOM::QualifiedName);
|
||||
|
||||
void progress_position_updated();
|
||||
|
||||
bool is_determinate() const { return has_attribute(HTML::AttributeNames::value); }
|
||||
};
|
||||
|
||||
}
|
||||
|
||||
WRAPPER_HACK(HTMLProgressElement, Web::HTML)
|
||||
|
||||
Reference in New Issue
Block a user