LibWeb: Make Node::is_text() return true for CDATASection nodes

Browse Source

CDATASection inherits from Text, and so it was incorrect for them to
claim not to be Text nodes.

This fixes at least two WPT subtests. :^)

It also exposed a bug in the DOM Parsing and Serialization spec,
where we're not told how to serialize CDATASection nodes.

Spec bug: https://github.com/w3c/DOM-Parsing/issues/38

...

This commit is contained in:

Andreas Kling

2024-11-19 15:35:31 +01:00

committed by Tim Ledbetter

parent 564dc0a434

commit 6ffc7ea36d

Notes: github-actions[bot] 2024-11-19 19:25:35 +00:00

Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/6ffc7ea36d4
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2441
Reviewed-by: https://github.com/tcl3 ✅

5 changed files with 2545 additions and 7 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

1089

Tests/LibWeb/Text/input/wpt-import/dom/common.js Normal file

File diff suppressed because it is too large Load Diff