eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-01 12:07:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS+LibWeb: Pass constants into execution context constructor

Browse Source 
The additional data being passed will be used in an upcoming commit.
Allows splitting the churn of modified function signatures from the
logically meaningful code change.

No behavior change.
This commit is contained in:
InvalidUsernameException
2026-03-27 23:45:15 +01:00
committed by Andreas Kling
parent 52c46483d1
commit 7002c47ce1
Notes: github-actions[bot] 2026-03-29 11:45:12 +00:00 
Author: https://github.com/InvalidUsernameException
Commit: https://github.com/LadybirdBrowser/ladybird/commit/7002c47ce1f
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8651
Reviewed-by: https://github.com/awesomekling
23 changed files with 72 additions and 69 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Libraries/LibJS/SourceTextModule.cpp
View File

@@ -33,7 +33,7 @@ SourceTextModule::SourceTextModule(Realm& realm, StringView filename, Script::Ho
GC::Ptr<Bytecode::Executable> executable,
GC::Ptr<SharedFunctionInstanceData> tla_shared_data)
: CyclicModule(realm, filename, has_top_level_await, move(requested_modules), host_defined)
, m_execution_context(ExecutionContext::create(0, 0, 0))
, m_execution_context(ExecutionContext::create(0, ReadonlySpan<Value> {}, 0))
, m_import_entries(move(import_entries))
, m_local_export_entries(move(local_export_entries))
, m_indirect_export_entries(move(indirect_export_entries))
@@ -503,16 +503,16 @@ ThrowCompletionOr<void> SourceTextModule::execute_module(VM& vm, GC::Ptr<Promise
VERIFY(m_has_top_level_await || m_executable);
u32 registers_and_locals_count = 0;
u32 constants_count = 0;
ReadonlySpan<Value> constants;
if (m_executable) {
registers_and_locals_count = m_executable->registers_and_locals_count;
constants_count = m_executable->constants.size();
constants = m_executable->constants;
}
// 1. Let moduleContext be a new ECMAScript code execution context.
auto& stack = vm.interpreter_stack();
auto* stack_mark = stack.top();
auto* module_context = stack.allocate(registers_and_locals_count, constants_count, 0);
auto* module_context = stack.allocate(registers_and_locals_count, constants, 0);
if (!module_context) [[unlikely]]
return vm.throw_completion<InternalError>(ErrorType::CallStackSizeExceeded);
ScopeGuard deallocate_guard = [&stack, stack_mark] { stack.deallocate(stack_mark); };