eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibGC+LibWeb: Mark two GC::Cell functions as MUST_UPCALL

Browse Source 
Let's make sure that subclasses always call their base class when
overriding these virtuals:

- void finalize()
- void visit_edges(Visitor&)
This commit is contained in:
Andreas Kling
2026-01-29 20:46:37 +01:00
committed by Jelle Raaijmakers
parent 853716fec3
commit 706eb0018c
Notes: github-actions[bot] 2026-02-06 12:53:01 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/706eb0018cd
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7773
Reviewed-by: https://github.com/gmta
Reviewed-by: https://github.com/shannonbooth
16 changed files with 25 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibWeb/HTML/EventSource.cpp
View File

@@ -178,6 +178,8 @@ void EventSource::initialize(JS::Realm& realm)
// https://html.spec.whatwg.org/multipage/server-sent-events.html#garbage-collection
void EventSource::finalize()
{
Base::finalize();
// If an EventSource object is garbage collected while its connection is still open, the user agent must abort any
// instance of the fetch algorithm opened by this EventSource.
if (m_ready_state != ReadyState::Closed) {