eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-27 18:17:22 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibGC+LibWeb: Mark two GC::Cell functions as MUST_UPCALL

Browse Source 
Let's make sure that subclasses always call their base class when
overriding these virtuals:

- void finalize()
- void visit_edges(Visitor&)
This commit is contained in:
Andreas Kling
2026-01-29 20:46:37 +01:00
committed by Jelle Raaijmakers
parent 853716fec3
commit 706eb0018c
Notes: github-actions[bot] 2026-02-06 12:53:01 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/706eb0018cd
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7773
Reviewed-by: https://github.com/gmta
Reviewed-by: https://github.com/shannonbooth
16 changed files with 25 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
Libraries/LibWeb/ResizeObserver/ResizeObserver.cpp
View File

@@ -49,6 +49,7 @@ void ResizeObserver::visit_edges(JS::Cell::Visitor& visitor)
void ResizeObserver::finalize()
{
Base::finalize();
if (m_document && m_list_node.is_in_list())
m_document->unregister_resize_observer({}, *this);
}