eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Parse @counter-style negative descriptor

Browse Source
This commit is contained in:
Callum Law
2026-01-31 21:24:22 +13:00
committed by Sam Atkins
parent f60bfd9e9e
commit 70c8d8746f
Notes: github-actions[bot] 2026-02-06 10:38:04 +00:00 
Author: https://github.com/Calme1709
Commit: https://github.com/LadybirdBrowser/ladybird/commit/70c8d8746f5
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7708
Reviewed-by: https://github.com/AtkinsSJ ✅
11 changed files with 92 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
Libraries/LibWeb/CSS/Parser/ValueParsing.cpp
View File

@@ -2710,6 +2710,29 @@ Optional<FlyString> Parser::parse_counter_style_name(TokenStream<ComponentValue>
return custom_ident;
}
// https://drafts.csswg.org/css-counter-styles-3/#typedef-symbol
RefPtr<StyleValue const> Parser::parse_symbol_value(TokenStream<ComponentValue>& tokens)
{
// <symbol> = <string> | <image> | <custom-ident>
// Note: The <image> syntax in <symbol> is currently at-risk. No implementations have plans to implement it
// currently, and it complicates some usages of counter() in ways that haven’t been fully handled.
// NB: Given the above we don't currently support <image> here - we may need to revisit this if other browsers implement it.
auto transaction = tokens.begin_transaction();
tokens.discard_whitespace();
if (auto string_value = parse_string_value(tokens)) {
transaction.commit();
return string_value;
}
if (auto custom_ident_value = parse_custom_ident_value(tokens, {})) {
transaction.commit();
return custom_ident_value;
}
return nullptr;
}
RefPtr<StyleValue const> Parser::parse_ratio_value(TokenStream<ComponentValue>& tokens)
{
if (auto ratio = parse_ratio(tokens); ratio.has_value())