eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Pass old parent's root to Node::removed_from()

Browse Source 
This will allow nodes to access the root they've just been removed from.
This commit is contained in:
Andreas Kling
2025-01-23 17:37:18 +01:00
committed by Andreas Kling
parent d465e2aa2b
commit 7269fc3e52
Notes: github-actions[bot] 2025-01-23 20:40:20 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/7269fc3e52c
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/3345
Reviewed-by: https://github.com/AtkinsSJ
39 changed files with 65 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Libraries/LibWeb/HTML/HTMLDialogElement.cpp
View File

@@ -41,9 +41,9 @@ void HTMLDialogElement::visit_edges(JS::Cell::Visitor& visitor)
visitor.visit(m_close_watcher);
}
void HTMLDialogElement::removed_from(Node* old_parent)
void HTMLDialogElement::removed_from(Node* old_parent, Node& old_root)
{
HTMLElement::removed_from(old_parent);
HTMLElement::removed_from(old_parent, old_root);
// 1. If removedNode's close watcher is not null, then:
if (m_close_watcher) {