eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Selection toString focused text control delegation

Browse Source 
Allows selected text in form controls to be copied to clipboard.
This commit is contained in:
Jonathan Gamble
2025-12-31 14:34:58 -06:00
committed by Shannon Booth
parent 451177f1f4
commit 7385569a02
Notes: github-actions[bot] 2026-01-02 17:41:12 +00:00 
Author: https://github.com/jonbgamble
Commit: https://github.com/LadybirdBrowser/ladybird/commit/7385569a024
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/7292
Reviewed-by: https://github.com/shannonbooth ✅
12 changed files with 140 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
Libraries/LibWeb/Selection/Selection.cpp
View File

@@ -14,6 +14,7 @@
#include <LibWeb/DOM/Range.h>
#include <LibWeb/DOM/Text.h>
#include <LibWeb/GraphemeEdgeTracker.h>
#include <LibWeb/HTML/FormAssociatedElement.h>
#include <LibWeb/Selection/Selection.h>
namespace Web::Selection {
@@ -505,8 +506,27 @@ bool Selection::contains_node(GC::Ref<DOM::Node> node, bool allow_partial_contai
&& (end_relative_position == DOM::RelativeBoundaryPointPosition::Equal || end_relative_position == DOM::RelativeBoundaryPointPosition::After);
}
Optional<Utf16String> Selection::try_form_control_selected_text_for_stringifier() const
{
// FIXME: According to https://bugzilla.mozilla.org/show_bug.cgi?id=85686#c69,
// sometimes you want the selection from a previously focused form text, probably
// when a button or context menu has temporarily stolen focus but page scripts
// still expect window.getSelection() to have the goodies.
auto const* form_element = as_if<HTML::FormAssociatedTextControlElement>(m_document->active_element());
if (!form_element)
return {};
return form_element->selected_text_for_stringifier();
}
Utf16String Selection::to_string() const
{
// https://w3c.github.io/selection-api/#dom-selection-stringifier
// If the selection is within a textarea or input element, it must return the
// selected substring in its value.
if (auto form_text = try_form_control_selected_text_for_stringifier(); form_text.has_value())
return form_text.release_value();
// FIXME: This needs more work to be compatible with other engines.
// See https://www.w3.org/Bugs/Public/show_bug.cgi?id=10583
if (!m_range)

1
Libraries/LibWeb/Selection/Selection.h
View File

@@ -56,6 +56,7 @@ public:
// Non-standard convenience accessor for the selection's range.
GC::Ptr<DOM::Range> range() const;
Optional<Utf16String> try_form_control_selected_text_for_stringifier() const;
// Non-standard accessor for the selection's document.
GC::Ref<DOM::Document> document() const;