eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-12 09:56:45 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/HTML: Support align attributes on table sections and rows

Browse Source 
thead, tbody, tfoot, tr, td, and th all have an `align` presentational
attribute with identical definitions. We previously only supported it
for td and th, and also allowed arbitrary text-align values instead of
the 4 dictated by the spec.
This commit is contained in:
Sam Atkins
2026-04-30 11:15:16 +01:00
committed by Jelle Raaijmakers
parent 0b4cea5b29
commit 73c4b77f68
Notes: github-actions[bot] 2026-04-30 13:21:30 +00:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/LadybirdBrowser/ladybird/commit/73c4b77f684
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/9177
Reviewed-by: https://github.com/gmta ✅
7 changed files with 373 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Libraries/LibWeb/HTML/HTMLTableCellElement.cpp
View File

@@ -71,16 +71,8 @@ void HTMLTableCellElement::apply_presentational_hints(GC::Ref<CSS::CascadedPrope
return;
}
if (name == HTML::AttributeNames::align) {
if (value.equals_ignoring_ascii_case("center"sv) || value.equals_ignoring_ascii_case("middle"sv)) {
cascaded_properties->set_property_from_presentational_hint(CSS::PropertyID::TextAlign, CSS::KeywordStyleValue::create(CSS::Keyword::LibwebCenter));
} else if (value.equals_ignoring_ascii_case("left"sv)) {
cascaded_properties->set_property_from_presentational_hint(CSS::PropertyID::TextAlign, CSS::KeywordStyleValue::create(CSS::Keyword::LibwebLeft));
} else if (value.equals_ignoring_ascii_case("right"sv)) {
cascaded_properties->set_property_from_presentational_hint(CSS::PropertyID::TextAlign, CSS::KeywordStyleValue::create(CSS::Keyword::LibwebRight));
} else {
if (auto parsed_value = parse_css_value(CSS::Parser::ParsingParams { document() }, value, CSS::PropertyID::TextAlign))
cascaded_properties->set_property_from_presentational_hint(CSS::PropertyID::TextAlign, parsed_value.release_nonnull());
}
if (auto parsed_value = parse_table_child_element_align_value(value))
cascaded_properties->set_property_from_presentational_hint(CSS::PropertyID::TextAlign, parsed_value.release_nonnull());
return;
}
if (name == HTML::AttributeNames::width) {