eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-12 01:46:46 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/HTML: Support align attributes on table sections and rows

Browse Source 
thead, tbody, tfoot, tr, td, and th all have an `align` presentational
attribute with identical definitions. We previously only supported it
for td and th, and also allowed arbitrary text-align values instead of
the 4 dictated by the spec.
This commit is contained in:
Sam Atkins
2026-04-30 11:15:16 +01:00
committed by Jelle Raaijmakers
parent 0b4cea5b29
commit 73c4b77f68
Notes: github-actions[bot] 2026-04-30 13:21:30 +00:00 
Author: https://github.com/AtkinsSJ
Commit: https://github.com/LadybirdBrowser/ladybird/commit/73c4b77f684
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/9177
Reviewed-by: https://github.com/gmta ✅
7 changed files with 373 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Libraries/LibWeb/HTML/HTMLTableSectionElement.cpp
View File

@@ -108,6 +108,7 @@ bool HTMLTableSectionElement::is_presentational_hint(FlyString const& name) cons
return true;
return first_is_one_of(name,
HTML::AttributeNames::align,
HTML::AttributeNames::background,
HTML::AttributeNames::bgcolor,
HTML::AttributeNames::height);
@@ -117,8 +118,12 @@ void HTMLTableSectionElement::apply_presentational_hints(GC::Ref<CSS::CascadedPr
{
Base::apply_presentational_hints(cascaded_properties);
for_each_attribute([&](auto& name, auto& value) {
if (name == HTML::AttributeNames::align) {
if (auto parsed_value = parse_table_child_element_align_value(value))
cascaded_properties->set_property_from_presentational_hint(CSS::PropertyID::TextAlign, parsed_value.release_nonnull());
}
// https://html.spec.whatwg.org/multipage/rendering.html#tables-2:encoding-parsing-and-serializing-a-url
if (name == HTML::AttributeNames::background) {
else if (name == HTML::AttributeNames::background) {
if (auto parsed_value = document().encoding_parse_url(value); parsed_value.has_value())
cascaded_properties->set_property_from_presentational_hint(CSS::PropertyID::BackgroundImage, CSS::StyleValueList::create({ CSS::ImageStyleValue::create(*parsed_value) }, CSS::StyleValueList::Separator::Comma));
}