eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-02 12:32:20 +02:00
Code Issues Packages Projects Releases Wiki Activity

Meta+Userland: Simplify some formatters

Browse Source 
These are mostly minor mistakes I've encountered while working on the
removal of StringView(char const*). The usage of builder.put_string over
Format<FormatString>::format is preferrable as it will avoid the
indirection altogether when there's no formatting to be done. Similarly,
there is no need to do format(builder, "{}", number) when
builder.put_u64(number) works equally well.

Additionally a few Strings where only constant strings were used are
replaced with StringViews.
This commit is contained in:
sin-ack
2022-07-11 20:23:24 +00:00
committed by Andreas Kling
parent 7da00bfa8d
commit 7456904a39
Notes: sideshowbarker 2024-07-17 09:27:58 +09:00 
Author: https://github.com/sin-ack
Commit: https://github.com/SerenityOS/serenity/commit/7456904a39
Pull-request: https://github.com/SerenityOS/serenity/pull/14555
Reviewed-by: https://github.com/Dexesttp ✅
Reviewed-by: https://github.com/kleinesfilmroellchen
9 changed files with 64 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Meta/Lagom/Tools/CodeGenerators/LibUnicode/GenerateUnicodeDateTimeFormat.cpp
View File

@@ -530,7 +530,7 @@ template<>
struct AK::Formatter<Unicode::HourCycle> : Formatter<FormatString> {
ErrorOr<void> format(FormatBuilder& builder, Unicode::HourCycle hour_cycle)
{
return Formatter<FormatString>::format(builder, "{}", to_underlying(hour_cycle));
return builder.put_u64(to_underlying(hour_cycle));
}
};