eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb/WebDriver: Add a FIXME about allowing await in script bodies

Browse Source 
There will soon only be a couple of remaining script execution WPT
promise.py failures. This comment is to explain why.
This commit is contained in:
Timothy Flynn
2025-04-11 12:57:49 -04:00
committed by Tim Flynn
parent eb0a51faf0
commit 7539d808cd
Notes: github-actions[bot] 2025-04-11 18:38:18 +00:00 
Author: https://github.com/trflynn89
Commit: https://github.com/LadybirdBrowser/ladybird/commit/7539d808cdf
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4326
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Libraries/LibWeb/WebDriver/ExecuteScript.cpp
View File

@@ -34,6 +34,8 @@ static JS::ThrowCompletionOr<JS::Value> execute_a_function_body(HTML::BrowsingCo
auto& realm = environment_settings.realm();
auto& global_scope = realm.global_environment();
// FIXME: This does not handle scripts which contain `await` statements. It is not as as simple as declaring this
// function async, unfortunately. See: https://github.com/w3c/webdriver/issues/1436
auto source_text = ByteString::formatted(
R"~~~(function() {{
{}