eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-01 12:07:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Everywhere: Switch from (void) to [[maybe_unused]] (#4473)

Browse Source 
Problem:
- `(void)` simply casts the expression to void. This is understood to
  indicate that it is ignored, but this is really a compiler trick to
  get the compiler to not generate a warning.

Solution:
- Use the `[[maybe_unused]]` attribute to indicate the value is unused.

Note:
- Functions taking a `(void)` argument list have also been changed to
  `()` because this is not needed and shows up in the same grep
  command.
This commit is contained in:
Lenny Maiorani
2020-12-20 16:09:48 -07:00
committed by GitHub
parent 4421d98e30
commit 765936ebae
Notes: sideshowbarker 2024-07-19 00:43:22 +09:00 
Author: https://github.com/ldm5180
Commit: https://github.com/SerenityOS/serenity/commit/765936ebaed
Pull-request: https://github.com/SerenityOS/serenity/pull/4473
Reviewed-by: https://github.com/bugaevc
103 changed files with 219 additions and 362 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Kernel/FileSystem/BlockBasedFileSystem.cpp
View File

@@ -290,7 +290,7 @@ void BlockBasedFS::flush_specific_block_if_needed(unsigned index)
file_description().seek(base_offset, SEEK_SET);
// FIXME: Should this error path be surfaced somehow?
auto entry_data_buffer = UserOrKernelBuffer::for_kernel_buffer(entry.data);
(void)file_description().write(entry_data_buffer, block_size());
[[maybe_unused]] auto rc = file_description().write(entry_data_buffer, block_size());
cleaned_entries.append(&entry);
}
});
@@ -311,7 +311,7 @@ void BlockBasedFS::flush_writes_impl()
file_description().seek(base_offset, SEEK_SET);
// FIXME: Should this error path be surfaced somehow?
auto entry_data_buffer = UserOrKernelBuffer::for_kernel_buffer(entry.data);
(void)file_description().write(entry_data_buffer, block_size());
[[maybe_unused]] auto rc = file_description().write(entry_data_buffer, block_size());
++count;
});
cache().mark_all_clean();