eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-03 04:52:06 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Validate operator count when parsing a calculation

Browse Source 
Previously, we would allow calc values such as `calc(min(1 2))`, which
would be simplified to `calc(3)` because we assumed that numbers not
separated by an operator represented a sum. We now validate that the
number of operators we see is as we would expect before collecting
these values into a sum node.
This commit is contained in:
Tim Ledbetter
2025-06-30 14:07:30 +01:00
committed by Sam Atkins
parent 43778e9493
commit 78b6032940
Notes: github-actions[bot] 2025-07-02 09:14:07 +00:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/78b60329402
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/5243
Reviewed-by: https://github.com/AtkinsSJ ✅
Reviewed-by: https://github.com/konradekk
14 changed files with 646 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

69
Tests/LibWeb/Text/input/wpt-import/css/css-values/minmax-angle-invalid.html Normal file
View File

@@ -0,0 +1,69 @@
<!DOCTYPE html>
<link rel="help" href="https://drafts.csswg.org/css-values-4/#comp-func">
<link rel="help" href="https://drafts.csswg.org/css-values-4/#angles">
<link rel="help" href="https://drafts.csswg.org/css-values-4/#calc-type-checking">
<link rel="author" title="Xiaocheng Hu" href="mailto:xiaochengh@chromium.org">
<script src="../../resources/testharness.js"></script>
<script src="../../resources/testharnessreport.js"></script>
<script src="../support/parsing-testcommon.js"></script>
<script>
function test_invalid_angle(value) {
test_invalid_value('transform', `rotate(${value})`);
}
// Syntax checking
test_invalid_angle('min()');
test_invalid_angle('min( )');
test_invalid_angle('min(,)');
test_invalid_angle('min(1dag)');
test_invalid_angle('min(1deg, )');
test_invalid_angle('min(, 1deg)');
test_invalid_angle('min(1deg + )');
test_invalid_angle('min(1deg - )');
test_invalid_angle('min(1deg * )');
test_invalid_angle('min(1deg / )');
test_invalid_angle('min(1deg 2deg)');
test_invalid_angle('min(1deg, , 2deg)');
test_invalid_angle('max()');
test_invalid_angle('max( )');
test_invalid_angle('max(,)');
test_invalid_angle('max(1dag)');
test_invalid_angle('max(1deg, )');
test_invalid_angle('max(, 1deg)');
test_invalid_angle('max(1deg + )');
test_invalid_angle('max(1deg - )');
test_invalid_angle('max(1deg * )');
test_invalid_angle('max(1deg / )');
test_invalid_angle('max(1deg 2deg)');
test_invalid_angle('max(1deg, , 2deg)');
// Type checking
test_invalid_angle('min(0)');
test_invalid_angle('min(0%)');
test_invalid_angle('min(0px)');
test_invalid_angle('min(0s)');
test_invalid_angle('min(0Hz)');
test_invalid_angle('min(0dpi)');
test_invalid_angle('min(0fr)');
test_invalid_angle('min(1deg, 0)');
test_invalid_angle('min(1deg, 0%)');
test_invalid_angle('min(1deg, 0px)');
test_invalid_angle('min(1deg, 0s)');
test_invalid_angle('min(1deg, 0Hz)');
test_invalid_angle('min(1deg, 0dpi)');
test_invalid_angle('min(1deg, 0fr)');
test_invalid_angle('max(0)');
test_invalid_angle('max(0%)');
test_invalid_angle('max(0px)');
test_invalid_angle('max(0s)');
test_invalid_angle('max(0Hz)');
test_invalid_angle('max(0dpi)');
test_invalid_angle('max(0fr)');
test_invalid_angle('max(1deg, 0)');
test_invalid_angle('max(1deg, 0%)');
test_invalid_angle('max(1deg, 0px)');
test_invalid_angle('max(1deg, 0s)');
test_invalid_angle('max(1deg, 0Hz)');
test_invalid_angle('max(1deg, 0dpi)');
test_invalid_angle('max(1deg, 0fr)');
</script>