eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-27 10:07:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Validate grid-template-areas rectangles at parse time

Browse Source 
Move grid area rectangle computation and validation from layout to the
CSS parser. Named grid areas that don't form filled-in rectangles now
correctly invalidate the declaration per spec.
This commit is contained in:
Aliaksandr Kalenik
2026-02-21 12:36:20 +01:00
committed by Alexander Kalenik
parent 0206150b70
commit 795222fab3
Notes: github-actions[bot] 2026-02-21 20:47:29 +00:00 
Author: https://github.com/kalenikaliaksandr
Commit: https://github.com/LadybirdBrowser/ladybird/commit/795222fab30
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8058
11 changed files with 136 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
Tests/LibWeb/Text/expected/wpt-import/css/css-grid/grid-definition/grid-support-grid-template-areas-001.txt
View File

@@ -2,8 +2,7 @@ Harness status: OK
Found 45 tests
36 Pass
9 Fail
45 Pass
Pass 'grid' with: grid-template-areas: none;
Pass 'grid' with: grid-template-areas: "a";
Pass 'grid' with: grid-template-areas: ".";
@@ -41,12 +40,12 @@ Pass 'grid' with: grid-template-areas: "a b c" "d e";
Pass 'grid' with: grid-template-areas: "a b"-"c d";
Pass 'grid' with: grid-template-areas: "a b" - "c d";
Pass 'grid' with: grid-template-areas: "a b" . "c d";
Fail 'grid' with: grid-template-areas: "a b a";
Fail 'grid' with: grid-template-areas: "a" "b" "a";
Fail 'grid' with: grid-template-areas: "a b" "b b";
Fail 'grid' with: grid-template-areas: "b a" "b b";
Fail 'grid' with: grid-template-areas: "a b" "b a";
Fail 'grid' with: grid-template-areas: "a ." ". a";
Fail 'grid' with: grid-template-areas: ",";
Fail 'grid' with: grid-template-areas: "10%";
Fail 'grid' with: grid-template-areas: "USD$";
Pass 'grid' with: grid-template-areas: "a b a";
Pass 'grid' with: grid-template-areas: "a" "b" "a";
Pass 'grid' with: grid-template-areas: "a b" "b b";
Pass 'grid' with: grid-template-areas: "b a" "b b";
Pass 'grid' with: grid-template-areas: "a b" "b a";
Pass 'grid' with: grid-template-areas: "a ." ". a";
Pass 'grid' with: grid-template-areas: ",";
Pass 'grid' with: grid-template-areas: "10%";
Pass 'grid' with: grid-template-areas: "USD$";