eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 01:35:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWebView: Show a better error for invalid download dir in headless

Browse Source 
Previously if the directory returned by `downloads_directory()` didn't
exist (or wasn't a directory) when taking a screnshot in headless mode
we try to ask the user for the download directory and fail with the
unhelpful error: QWidget: Must construct a QApplication before a QWidget
This commit is contained in:
Callum Law
2025-09-16 11:16:53 +12:00
committed by Tim Flynn
parent b9da7baac4
commit 7a9b1a8033
Notes: github-actions[bot] 2025-09-16 14:40:24 +00:00 
Author: https://github.com/Calme1709
Commit: https://github.com/LadybirdBrowser/ladybird/commit/7a9b1a80330
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/6209
Reviewed-by: https://github.com/trflynn89 ✅
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
Libraries/LibWebView/Application.cpp
View File

@@ -589,6 +589,11 @@ ErrorOr<LexicalPath> Application::path_for_downloaded_file(StringView file) cons
auto downloads_directory = Core::StandardPaths::downloads_directory();
if (!FileSystem::is_directory(downloads_directory)) {
if (browser_options().headless_mode.has_value()) {
dbgln("Unable to ask user for download folder in headless mode, please ensure {} is a directory or use the XDG_DOWNLOAD_DIR environment variable to set a new download directory", downloads_directory);
return Error::from_errno(ENOENT);
}
auto maybe_downloads_directory = ask_user_for_download_folder();
if (!maybe_downloads_directory.has_value())
return Error::from_errno(ECANCELED);