eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-15 03:17:05 +02:00
Code Issues Packages Projects Releases Wiki Activity

Shell: Do not assume that stdin/stdout is a TTY

Browse Source 
This closes #2989.
This commit is contained in:
AnotherTest
2020-08-05 10:00:01 +04:30
committed by Andreas Kling
parent 70eb7aa627
commit 7b15c85ff5
Notes: sideshowbarker 2024-07-19 04:15:54 +09:00 
Author: https://github.com/alimpfard
Commit: https://github.com/SerenityOS/serenity/commit/7b15c85ff5e
Pull-request: https://github.com/SerenityOS/serenity/pull/2995
Issue: https://github.com/SerenityOS/serenity/issues/2989
Reviewed-by: https://github.com/awesomekling
3 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
Shell/Shell.cpp
View File

@@ -58,7 +58,7 @@ extern char** environ;
void Shell::print_path(const String& path)
{
if (s_disable_hyperlinks) {
if (s_disable_hyperlinks || !m_is_interactive) {
printf("%s", path.characters());
return;
}
@@ -1092,9 +1092,17 @@ Shell::Shell()
int rc = gethostname(hostname, Shell::HostNameSize);
if (rc < 0)
perror("gethostname");
rc = ttyname_r(0, ttyname, Shell::TTYNameSize);
if (rc < 0)
perror("ttyname_r");
auto istty = isatty(STDIN_FILENO);
m_is_interactive = istty;
if (istty) {
rc = ttyname_r(0, ttyname, Shell::TTYNameSize);
if (rc < 0)
perror("ttyname_r");
} else {
ttyname[0] = 0;
}
{
auto* cwd = getcwd(nullptr, 0);