eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-11 17:37:33 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Move checked-state invalidation into a helper

Browse Source 
HTMLInputElement had two call sites spelling out the same checked and
unchecked pseudo-class invalidation set. Move that selector policy into
FormControlInvalidator.

This keeps the input element responsible for detecting state changes,
while CSS::Invalidation owns the affected selector features.
This commit is contained in:
Andreas Kling
2026-04-29 11:21:08 +02:00
committed by Alexander Kalenik
parent 84f4140226
commit 7c401b051b
Notes: github-actions[bot] 2026-04-29 13:50:29 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/7c401b051bb
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/9160
4 changed files with 50 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
Libraries/LibWeb/HTML/HTMLInputElement.cpp
View File

@@ -23,6 +23,7 @@
#include <LibWeb/CSS/CSSStyleProperties.h>
#include <LibWeb/CSS/CascadedProperties.h>
#include <LibWeb/CSS/ComputedProperties.h>
#include <LibWeb/CSS/Invalidation/FormControlInvalidator.h>
#include <LibWeb/CSS/Parser/Parser.h>
#include <LibWeb/CSS/StyleValues/DisplayStyleValue.h>
#include <LibWeb/CSS/StyleValues/KeywordStyleValue.h>
@@ -206,13 +207,7 @@ void HTMLInputElement::set_checked(bool checked)
m_checked = checked;
invalidate_style(
DOM::StyleInvalidationReason::HTMLInputElementSetChecked,
{
{ .type = CSS::InvalidationSet::Property::Type::PseudoClass, .value = CSS::PseudoClass::Checked },
{ .type = CSS::InvalidationSet::Property::Type::PseudoClass, .value = CSS::PseudoClass::Unchecked },
},
{});
CSS::Invalidation::invalidate_style_after_checked_state_change(*this, DOM::StyleInvalidationReason::HTMLInputElementSetChecked);
set_needs_repaint();
}
@@ -1596,13 +1591,7 @@ void HTMLInputElement::type_attribute_changed(TypeAttributeState old_state, Type
auto old_value_attribute_mode = value_attribute_mode_for_type_state(old_state);
if (checked_applies(old_state) != checked_applies(new_state)) {
invalidate_style(
DOM::StyleInvalidationReason::HTMLInputElementSetType,
{
{ .type = CSS::InvalidationSet::Property::Type::PseudoClass, .value = CSS::PseudoClass::Checked },
{ .type = CSS::InvalidationSet::Property::Type::PseudoClass, .value = CSS::PseudoClass::Unchecked },
},
{});
CSS::Invalidation::invalidate_style_after_checked_state_change(*this, DOM::StyleInvalidationReason::HTMLInputElementSetType);
}
// 1. If the previous state of the element's type attribute put the value IDL attribute in the value mode, and the element's