eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-09 00:22:36 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Update spec text for set_value_of_indexed_property

Browse Source 
https://github.com/whatwg/html/pull/11932 resolved the AD-HOC comment
and adjusted the spec text.
This commit is contained in:
Lorenz A
2025-11-20 14:49:09 +01:00
committed by Shannon Booth
parent 48f08ba09d
commit 7e50dcb687
Notes: github-actions[bot] 2026-01-06 12:04:53 +00:00 
Author: https://github.com/lpas
Commit: https://github.com/LadybirdBrowser/ladybird/commit/7e50dcb6878
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/6749
Reviewed-by: https://github.com/Psychpsyo
Reviewed-by: https://github.com/gmta
Reviewed-by: https://github.com/konradekk
Reviewed-by: https://github.com/shannonbooth
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
Libraries/LibWeb/HTML/HTMLOptionsCollection.cpp
View File

@@ -99,18 +99,18 @@ WebIDL::ExceptionOr<void> HTMLOptionsCollection::set_value_of_indexed_property(u
auto root_element = root();
if (index >= length) {
// 3. Let n be index minus length.
auto n = index - length;
// 3. Let delta be index minus length
auto delta = index - length;
// 4. If n is greater than zero, then append a DocumentFragment consisting of n-1 new option elements with no attributes and no child nodes to the select element on which the HTMLOptionsCollection is rooted.
if (n > 0) {
// AD-HOC: https://github.com/whatwg/html/issues/11905
for (WebIDL::UnsignedLong i = 0; i < n; i++) {
// 4. If delta is greater than zero, then append a DocumentFragment consisting of delta new option elements with
// no attributes and no child nodes to the select element on which the HTMLOptionsCollection is rooted.
if (delta > 0) {
for (WebIDL::UnsignedLong i = 0; i < delta; i++) {
TRY(root_element->append_child(TRY(DOM::create_element(root_element->document(), HTML::TagNames::option, Namespace::HTML))));
}
}
// 5. If n is greater than or equal to zero, append value to the select element.
// 5. If delta is greater than or equal to zero, append value to the select element.
TRY(root_element->append_child(option));
} else {
// 5 (cont). Otherwise, replace the indexth element in the collection by value.