eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-30 19:47:17 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibGfx+Userland: Make Gfx::SystemTheme propagate errors

Browse Source 
This patch introduces error propagation to Gfx::SystemTheme to remove
instances of release_value_but_fixme_should_propagate_errors().

Userland applications that have been affected by this change have been
updated to utilise this propagation and as a result 4 such instances of
the aforementioned method have been removed.
This commit is contained in:
Cygnix Proto
2022-12-06 16:26:13 +00:00
committed by Linus Groh
parent bdd9bc16de
commit 806a55eda1
Notes: sideshowbarker 2024-07-17 10:54:57 +09:00 
Author: https://github.com/CygnixProto 🔰
Commit: https://github.com/SerenityOS/serenity/commit/806a55eda1
Pull-request: https://github.com/SerenityOS/serenity/pull/16335
Reviewed-by: https://github.com/ADKaster
Reviewed-by: https://github.com/davidot
Reviewed-by: https://github.com/linusg ✅
15 changed files with 64 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Libraries/LibGUI/AbstractThemePreview.h
View File

@@ -24,7 +24,7 @@ public:
Gfx::Palette const& preview_palette() const { return m_preview_palette; }
void set_preview_palette(Gfx::Palette const&);
void set_theme_from_file(Core::File&);
ErrorOr<void> set_theme_from_file(Core::File&);
void set_theme(Core::AnonymousBuffer const&);
void paint_window(StringView title, Gfx::IntRect const& rect, Gfx::WindowTheme::WindowState, Gfx::Bitmap const& icon, int button_count = 3);