eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-27 02:05:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Use correct error for invalid rule in nested insertRule

Browse Source 
When we try to insert a disallowed (non-nested) statement into a
CSSGroupingRule we should throw a `HierarchyRequestError` as it being
disallowed is a "constraint specified by CSS". Previously we would rely
on `Parser::is_valid_in_the_current_context` and throw a Syntax error.

There are more constraints to be implemented.
This commit is contained in:
Callum Law
2025-06-21 21:57:57 +12:00
committed by Sam Atkins
parent ef7ba02842
commit 80ea865b19
Notes: github-actions[bot] 2025-06-23 11:53:52 +00:00 
Author: https://github.com/Calme1709
Commit: https://github.com/LadybirdBrowser/ladybird/commit/80ea865b197
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/5158
Reviewed-by: https://github.com/AtkinsSJ ✅
Reviewed-by: https://github.com/tcl3
4 changed files with 139 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
Tests/LibWeb/Text/expected/wpt-import/css/cssom/CSSGroupingRule-insertRule.txt Normal file
View File

@@ -0,0 +1,12 @@
Harness status: OK
Found 7 tests
7 Pass
Pass index before first
Pass index after final
Pass index not specified
Pass index exceeds length
Pass CSS parsing error
Pass constraint violation
Pass disallowed namespace rule