eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-25 17:25:08 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Support symbols() function in <counter-style>

Browse Source
This commit is contained in:
Callum Law
2026-02-27 15:36:12 +13:00
committed by Sam Atkins
parent f6eccc629c
commit 81cb968beb
Notes: github-actions[bot] 2026-02-27 16:27:03 +00:00 
Author: https://github.com/Calme1709
Commit: https://github.com/LadybirdBrowser/ladybird/commit/81cb968beba
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/8196
Reviewed-by: https://github.com/AtkinsSJ ✅
11 changed files with 344 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
Libraries/LibWeb/CSS/Parser/ValueParsing.cpp
View File

@@ -2713,15 +2713,61 @@ Optional<FlyString> Parser::parse_counter_style_name(TokenStream<ComponentValue>
RefPtr<StyleValue const> Parser::parse_counter_style_value(TokenStream<ComponentValue>& tokens)
{
// <counter-style> = <counter-style-name> | <symbols()>
// <symbols()> = symbols( <symbols-type>? [ <string> | <image> ]+ )
// <symbols-type> = cyclic | numeric | alphabetic | symbolic | fixed
auto transaction = tokens.begin_transaction();
tokens.discard_whitespace();
// <counter-style-name>
if (auto const& counter_style_name = parse_counter_style_name(tokens); counter_style_name.has_value()) {
transaction.commit();
return CounterStyleStyleValue::create(counter_style_name.value());
}
// FIXME: Support <symbols()>
// <symbols()>
auto const& maybe_function_token = tokens.consume_a_token();
if (maybe_function_token.is_function("symbols"sv)) {
TokenStream argument_tokens { maybe_function_token.function().value };
// <symbols-type>?
// NB: <symbols-type> defaults to symbolic if not provided.
SymbolsType symbols_type = SymbolsType::Symbolic;
if (auto keyword = parse_keyword_value(argument_tokens); keyword) {
auto maybe_symbols_type = keyword_to_symbols_type(keyword->to_keyword());
if (!maybe_symbols_type.has_value())
return nullptr;
symbols_type = maybe_symbols_type.value();
}
// [ <string> | <image> ]+
// FIXME: In line with <symbol> we don't support <image> here - we may need to revisit this if other browsers
// implement it.
Vector<FlyString> symbols;
while (argument_tokens.has_next_token()) {
auto maybe_string = parse_string_value(argument_tokens);
if (!maybe_string)
break;
symbols.append(maybe_string->string_value());
}
argument_tokens.discard_whitespace();
if (argument_tokens.has_next_token())
return nullptr;
// https://drafts.csswg.org/css-counter-styles-3/#symbols-function
// If the system is alphabetic or numeric, there must be at least two <string>s or <image>s, or else the function is invalid.
if (symbols.is_empty() || (first_is_one_of(symbols_type, SymbolsType::Alphabetic, SymbolsType::Numeric) && symbols.size() < 2))
return nullptr;
transaction.commit();
return CounterStyleStyleValue::create(CounterStyleStyleValue::SymbolsFunction { symbols_type, move(symbols) });
}
return nullptr;
}