eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-05 06:32:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibJS: Oops, "instanceof" was backwards!

Browse Source 
Fix the "instanceof" operator to check if the constructor's prototype
property occurs anywhere in the prototype chain of the instance object.

This patch also adds Object.setPrototypeOf() to make it possible to
create a test for this bug.

Thanks to DexesTTP for pointing this out! :^)
This commit is contained in:
Andreas Kling
2020-03-28 19:48:12 +01:00
parent e5ebdb9bca
commit 82ca7ae1f8
Notes: sideshowbarker 2024-07-19 08:05:26 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/82ca7ae1f80
5 changed files with 53 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
Libraries/LibJS/Runtime/Object.cpp
View File

@@ -44,6 +44,15 @@ Object::~Object()
{
}
bool Object::has_prototype(const Object* prototype) const
{
for (auto* object = m_prototype; object; object = object->prototype()) {
if (object == prototype)
return true;
}
return false;
}
Optional<Value> Object::get_own_property(const Object& this_object, const FlyString& property_name) const
{
auto value_here = m_properties.get(property_name);