eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-04-26 17:55:07 +02:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Move setting of Web object prototypes to initialize()

Browse Source 
This needs to happen before prototype/constructor intitialization can be
made lazy. Otherwise, GC could run during the C++ constructor and try to
collect the object currently being created.
This commit is contained in:
Timothy Flynn
2023-01-10 06:28:20 -05:00
committed by Andreas Kling
parent 7bd8fd000f
commit 834202aeb9
Notes: sideshowbarker 2024-07-17 01:51:10 +09:00 
Author: https://github.com/trflynn89
Commit: https://github.com/SerenityOS/serenity/commit/834202aeb9
Pull-request: https://github.com/SerenityOS/serenity/pull/16945
Reviewed-by: https://github.com/alimpfard
339 changed files with 1294 additions and 187 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
Userland/Libraries/LibWeb/DOM/MutationObserver.cpp
View File

@@ -21,7 +21,6 @@ MutationObserver::MutationObserver(JS::Realm& realm, JS::GCPtr<WebIDL::CallbackT
: PlatformObject(realm)
, m_callback(move(callback))
{
set_prototype(&Bindings::cached_web_prototype(realm, "MutationObserver"));
// 1. Set this’s callback to callback.
@@ -32,6 +31,12 @@ MutationObserver::MutationObserver(JS::Realm& realm, JS::GCPtr<WebIDL::CallbackT
MutationObserver::~MutationObserver() = default;
void MutationObserver::initialize(JS::Realm& realm)
{
Base::initialize(realm);
set_prototype(&Bindings::ensure_web_prototype<Bindings::MutationObserverPrototype>(realm, "MutationObserver"));
}
void MutationObserver::visit_edges(Cell::Visitor& visitor)
{
Base::visit_edges(visitor);