mirror of
https://github.com/LadybirdBrowser/ladybird
synced 2026-04-26 17:55:07 +02:00
LibWeb: Move setting of Web object prototypes to initialize()
This needs to happen before prototype/constructor intitialization can be made lazy. Otherwise, GC could run during the C++ constructor and try to collect the object currently being created.
This commit is contained in:
committed by
Andreas Kling
parent
7bd8fd000f
commit
834202aeb9
Notes:
sideshowbarker
2024-07-17 01:51:10 +09:00
Author: https://github.com/trflynn89 Commit: https://github.com/SerenityOS/serenity/commit/834202aeb9 Pull-request: https://github.com/SerenityOS/serenity/pull/16945 Reviewed-by: https://github.com/alimpfard
@@ -15,7 +15,12 @@ ProcessingInstruction::ProcessingInstruction(Document& document, DeprecatedStrin
|
||||
: CharacterData(document, NodeType::PROCESSING_INSTRUCTION_NODE, data)
|
||||
, m_target(target)
|
||||
{
|
||||
set_prototype(&Bindings::cached_web_prototype(document.realm(), "ProcessingInstruction"));
|
||||
}
|
||||
|
||||
void ProcessingInstruction::initialize(JS::Realm& realm)
|
||||
{
|
||||
Base::initialize(realm);
|
||||
set_prototype(&Bindings::ensure_web_prototype<Bindings::ProcessingInstructionPrototype>(realm, "ProcessingInstruction"));
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user