eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-01 12:07:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Kernel/FileSystem: Mark ext2 inode lookup cache non-const

Browse Source 
For the lookup cache, no method being declared const tried to modify it,
so it was easy to drop the mutable declaration on the HashMap member.
This commit is contained in:
Liav A
2022-08-06 18:07:03 +03:00
committed by Idan Horowitz
parent b04de3090f
commit 843bd43c5b
Notes: sideshowbarker 2024-07-17 07:07:16 +09:00 
Author: https://github.com/supercomputer7
Commit: https://github.com/SerenityOS/serenity/commit/843bd43c5b
Pull-request: https://github.com/SerenityOS/serenity/pull/14785
Reviewed-by: https://github.com/IdanHo ✅
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Kernel/FileSystem/Ext2FileSystem.cpp
View File

@@ -1499,9 +1499,9 @@ ErrorOr<NonnullLockRefPtr<Inode>> Ext2FS::create_inode(Ext2FSInode& parent_inode
return new_inode;
}
ErrorOr<void> Ext2FSInode::populate_lookup_cache() const
ErrorOr<void> Ext2FSInode::populate_lookup_cache()
{
MutexLocker locker(m_inode_lock);
VERIFY(m_inode_lock.is_exclusively_locked_by_current_thread());
if (!m_lookup_cache.is_empty())
return {};
HashMap<NonnullOwnPtr<KString>, InodeIndex> children;
@@ -1521,11 +1521,11 @@ ErrorOr<NonnullLockRefPtr<Inode>> Ext2FSInode::lookup(StringView name)
{
VERIFY(is_directory());
dbgln_if(EXT2_DEBUG, "Ext2FSInode[{}]:lookup(): Looking up '{}'", identifier(), name);
TRY(populate_lookup_cache());
InodeIndex inode_index;
{
MutexLocker locker(m_inode_lock);
TRY(populate_lookup_cache());
auto it = m_lookup_cache.find(name);
if (it == m_lookup_cache.end()) {
dbgln_if(EXT2_DEBUG, "Ext2FSInode[{}]:lookup(): '{}' not found", identifier(), name);