eliott/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird synced 2026-05-10 09:02:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Kernel+Tests: Remove inaccurate FIXME in sys$rmdir()

Browse Source 
We were already handling the rmdir("..") case by refusing to remove
directories that were not empty.

This patch removes a FIXME from January 2019 and adds a test. :^)
This commit is contained in:
Andreas Kling
2022-12-19 18:53:20 +01:00
parent 8d781d0216
commit 8619f2c6f3
Notes: sideshowbarker 2024-07-17 10:39:39 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/8619f2c6f3
Pull-request: https://github.com/SerenityOS/serenity/pull/16594
Reviewed-by: https://github.com/FalseHonesty
Reviewed-by: https://github.com/krkk
Reviewed-by: https://github.com/supercomputer7 ✅
Reviewed-by: https://github.com/xZise
2 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Kernel/FileSystem/VirtualFileSystem.cpp
View File

@@ -847,8 +847,6 @@ ErrorOr<void> VirtualFileSystem::rmdir(Credentials const& credentials, StringVie
if (last_component == "."sv)
return EINVAL;
// FIXME: We should return ENOTEMPTY if the last component of the path is ".."
if (!inode.is_directory())
return ENOTDIR;